Revert "Revert "[fuchsia] Add diagnostics directory to the set of remote dirs (flutter#14470)" (flutter#14566)"

miguelfrde · miguelfrde · commit dd2e5eb66c04 · 2020-01-02T11:04:02.000-08:00
This reverts commit 4312d37. Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the diagnostics directory will be present, this would be safe to do and the roller won't be blocked again.
diff --git a/shell/platform/fuchsia/flutter/component.cc b/shell/platform/fuchsia/flutter/component.cc
@@ -233,7 +233,7 @@ Application::Application(
                          << "): " << zx_status_get_string(status);
           return;
         }
-        const char* other_dirs[] = {"debug", "ctrl"};
+        const char* other_dirs[] = {"debug", "ctrl", "diagnostics"};
         // add other directories as RemoteDirs.
         for (auto& dir_str : other_dirs) {
           fidl::InterfaceHandle<fuchsia::io::Directory> dir;

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ Application::Application(`
`233`	`233`	`<< "): " << zx_status_get_string(status);`
`234`	`234`	`return;`
`235`	`235`	`}`
`236`		`- const char* other_dirs[] = {"debug", "ctrl"};`
	`236`	`+ const char* other_dirs[] = {"debug", "ctrl", "diagnostics"};`
`237`	`237`	`// add other directories as RemoteDirs.`
`238`	`238`	`for (auto& dir_str : other_dirs) {`
`239`	`239`	`fidl::InterfaceHandle<fuchsia::io::Directory> dir;`