Skip to content

Plans to support Socket.IO 2? #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OneSman7 opened this issue Jun 16, 2017 · 10 comments
Closed

Plans to support Socket.IO 2? #109

OneSman7 opened this issue Jun 16, 2017 · 10 comments
Assignees

Comments

@OneSman7
Copy link

There was an update to socket.io (https://socket.io/blog/socket-io-2-0-0/) which is not backward compatible with socket.io 1.
Do you have plans to support it?

Thanks

@miguelgrinberg
Copy link
Owner

miguelgrinberg commented Jun 16, 2017

I have tested the server with the 2.x JS clients and already addressed the only issue I've found, which is related to this item in their breaking changes list:

  • a breaking change related to utf-8 encoding in engine.io-parser

I have not looked at the non-breaking changes to see if there are any optimizations that can be added yet, but I plan to.

I'll leave this issue open to remind me to review that list.

@spumer
Copy link

spumer commented Aug 4, 2017

I try to use with 2.0.3 client library version, and websocket protocol did not work, only polling.
With 1.7.4 all works fine.

@miguelgrinberg
Copy link
Owner

Did you see any errors? I have been using the 2.x releases of the Socket.IO client without problem here.

@spumer
Copy link

spumer commented Aug 10, 2017

It's seems to be heizenbug. Cause on some systems websocket connection estabilshed, but client don't recevied socket.io connect message from the server and try to reconnect.

This occured when i force websocket through transports options.
If no transports set, browser try all transports, "ensure" websockets available and use it!

Bug occured on Win7 with Chrome, but not for all. Socket.IO 1 and 2 versions tested

I don't know what happend, really.

@kylegoetz
Copy link

kylegoetz commented Feb 1, 2018

For what it's worth, there's a second breaking change not mentioned in this issue's discussion so far: https://github.com/socketio/socket.io/releases has a list and the second issue is at socketio/socket.io-client#1058

I'm trying to look into it because when I emit packets from my Node.js v2 client the Python v1 server receives them and behaves correctly, but the reverse never succeeds: v1's emit() is never received by my Node.js v2 client.

@miguelgrinberg
Copy link
Owner

That is not a protocol change, but something specific to the Javascript implementation. It has no bearing on this server.

@kylegoetz
Copy link

OK thank you. I just changed the Python server's namespace from my custom one to the default namespace and the JS client actually receives the messages. Thanks for letting me know.

@ramazanpolat
Copy link

I've tried Firecamp (a chrome extension that can connect and test a socket.io server) with the sample code and found out that if you use empty string as namespace, everything works fine.

@Ankita130889
Copy link

When I try to send binary data from the python-socketio client to a nodejs server which is using socketio 2.0 protocol the server closes the connection and reconnects to start a new session.

Sending text data from the python-socketio client to the nodejs server using the socketio 2.0 protocol works fine.

@miguelgrinberg
Copy link
Owner

I'm not aware of any issues with the Socket.IO 2.x protocol at this time. Please open a new issues for any compatibility problems you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants