Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import statement for socketio in docs #289

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Add missing import statement for socketio in docs #289

merged 2 commits into from
Apr 19, 2019

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Apr 19, 2019

No description provided.

@faheel faheel changed the title Add missing import statement for socketio Add missing import statement for socketio in docs Apr 19, 2019
@miguelgrinberg
Copy link
Owner

@faheel Thanks. The error is actually that I used import engineio instead of import socketio. Can you please remove the engineio import?

@miguelgrinberg miguelgrinberg self-assigned this Apr 19, 2019
@faheel
Copy link
Contributor Author

faheel commented Apr 19, 2019

@miguelgrinberg Done.

@miguelgrinberg
Copy link
Owner

Thank you!

@miguelgrinberg miguelgrinberg merged commit cacb621 into miguelgrinberg:master Apr 19, 2019
@faheel faheel deleted the patch-1 branch April 23, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelgrinberg miguelgrinberg

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faheel @miguelgrinberg