Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you change the way it runs on macOS? #1145

Closed
rigroch opened this issue Oct 7, 2022 · 6 comments
Closed

Can you change the way it runs on macOS? #1145

rigroch opened this issue Oct 7, 2022 · 6 comments
Assignees
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. feature-candidate This issue might result in a feature to be implemented suggestion New feature or request

Comments

@rigroch
Copy link

rigroch commented Oct 7, 2022

In summary, use Channel like iOS.

Please use beginSheetModal instead of runModal. (runModal works the same as the way uses osascript you were written.)

guard let keywindow = NSApplication.shared.keyWindow else {
    result(nil)
    return
}

NSOpenPanel().beginSheetModal(for: keywindow) { response in
    
}

It appears more beautiful appearance, and to solve the issue.

@rigroch rigroch added the suggestion New feature or request label Oct 7, 2022
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Nov 1, 2022
@stuartmorgan
Copy link

runModal works the same as the way uses osascript you were written.

This isn't actually correct; an in-process runModal call would already be vastly better than osascript. The latter is not intended for use in GUI applications, and shows the dialog in a completely separate process, which creates significant issues around focus and window management.

@philenius philenius added the desktop The issue applies to Windows, Linux or MacOS implementations. label Apr 4, 2023
@philenius philenius added the feature-candidate This issue might result in a feature to be implemented label Apr 12, 2023
@philenius philenius reopened this Apr 12, 2023
@github-actions github-actions bot removed the stale label Apr 13, 2023
@ricardoboss
Copy link

Any updates on this? It would be really nice if the the lockParentWindow would actually work on macOS.

Docs for runModal: https://developer.apple.com/documentation/appkit/nsapplication/1428436-runmodal

@Hixie
Copy link

Hixie commented Feb 13, 2024

I imagine this would also fix #1445

@navaronbracke
Copy link
Collaborator

Closing this issue as a duplicate of #1492 since that issue has a better explanation of what needs to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. feature-candidate This issue might result in a feature to be implemented suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants