Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I remove CAMERA permission? #21

Closed
kgamecarter opened this issue Dec 27, 2018 · 14 comments
Closed

Can I remove CAMERA permission? #21

kgamecarter opened this issue Dec 27, 2018 · 14 comments
Labels
suggestion New feature or request
Milestone

Comments

@kgamecarter
Copy link

kgamecarter commented Dec 27, 2018

If I don't need FileType.CAMERA.
Can I remove CAMERA permission?

If my app has CAMERA permission. I need give google play privacy policy url.

@kgamecarter
Copy link
Author

I found camera permission is added by image_picker.
I think remove image_picker for FileType.IMAGE and FileType.CAMERA better.
Separate it for difference requirement.

@miguelpruivo
Copy link
Owner

If you don’t need it you don’t have to provide those permissions as well. The image_picker is just re-used here in order to prevent two packages but I get your idea. I’ll take in consideration.

@miguelpruivo miguelpruivo added the suggestion New feature or request label Dec 27, 2018
@kgamecarter
Copy link
Author

No. I don't give CAMERA permisiion in AndroidManifest.xml
But still appear CAMERA permission in app.
Untill I remove image_picker in my file_picker fork.

@kgamecarter
Copy link
Author

@miguelpruivo
Copy link
Owner

That’s right, I forgot the grantUriPermissions is set to true on the image_picker.

@miguelpruivo
Copy link
Owner

miguelpruivo commented Dec 27, 2018

I'll reopen so others may see this. I would like to have more feedback since I get the point, that it would be fine to have it separated in both plugins, but I can also understand that this is more reliable for some users since they have to only import one plugin and it will handle picking all file types.

Edit: @kgamecarter I don't get it. I've tried it right now in a clean installation (used the example app) and it only requires camera permission if you actually try to load a path from a camera, which is indeed expected, since you can't use the camera without the user giving permissions. Other than that, it won't trigger the camera permission. So, if you don't use picking from camera, you should be fine.

@miguelpruivo miguelpruivo reopened this Dec 27, 2018
@kgamecarter
Copy link
Author

Just this
1
Google play asks me privacy policy
2

@miguelpruivo
Copy link
Owner

Hum, I see. The privacy policies. This may be useful in the meantime.

@kgamecarter
Copy link
Author

kgamecarter commented Dec 27, 2018

OK. it is a nice sample
https://docs.google.com/document/d/14xHZa1PqxpgntwhStx0dnaiPOV1uDAY0RzQyF5GkPpw/edit

But if some one just need pick document or saved file. remove useless permission better.

@pushangupta
Copy link

@kgamecarter
You can easily fork the repo and remove the image picker from it.

@kgamecarter
Copy link
Author

Yes, I am maintaining my fork now.

@goftino
Copy link

goftino commented Feb 20, 2019

hi , I have this problem too, I want to remove the camera permission, plz help.

@miguelpruivo
Copy link
Owner

miguelpruivo commented Feb 20, 2019

This is a tricky one because the plugin supports picking files from camera so it will always have to have that permission.

One option will be removing this feature entirely and let users use this alongside with image_picker if needed.

@miguelpruivo miguelpruivo added this to the Goals milestone Mar 10, 2019
@miguelpruivo
Copy link
Owner

miguelpruivo commented Mar 12, 2019

Version 1.3.0 was deployed on dart pub and fixes this, alongside with other requested features and bug fixes. See changelog.

Make sure you clean and change your pubspec to the latest version: file_picker: ^1.3.0

Thank you all for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants