Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Other Languages Build Directories #3

Open
Noah-Kennedy opened this issue May 22, 2020 · 4 comments
Open

Support Other Languages Build Directories #3

Noah-Kennedy opened this issue May 22, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Noah-Kennedy
Copy link

Noah-Kennedy commented May 22, 2020

I noticed on the TODO page that there are currently no plans to support the build systems of any other languages. Would pull requests adding additional support be accepted?

@mihai-dinculescu
Copy link
Owner

Would pull requests adding additional support be accepted?

Of course! What do you have in mind?

@Noah-Kennedy
Copy link
Author

CMake for the moment, but I might be adding a few more to my fork before I start a PR.

I'd also be willing to add the code to verify that the directory really does pertain to the build system in question, by checking for specific sets of files or subdirectories (does it contain Cargo.toml and Cargo.lock, CMakeLists.txt, etc.).

@mihai-dinculescu
Copy link
Owner

CMake will be most welcome. Any build system really, as long as it doesn't over-complicate the tool with extra stuff (flags, etc.).

I have just added a check for the target folder, so that should be fine now.

You might want to rebase your fork, I've been changing quite a lot of things in the past 48 hours.

@mihai-dinculescu mihai-dinculescu added help wanted Extra attention is needed enhancement New feature or request labels Nov 18, 2020
@Timmmm
Copy link
Contributor

Timmmm commented Feb 17, 2021

Dart generates a .dart_tool directory which can get quite big. Would be good to have an option for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants