-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D2Net to kornia #84
Comments
Hey. Thanks for reaching out - sounds like a neat idea! I was planning to work on a cleaner implementation at some point, so why not integrate it with Kornia. If I understand it correctly, I simply need to create a new D2Net nn.Module similar to e.g. the HardNet one. I'll give it a try in the following weeks and reach out with a PR when it's ready! |
Sounds great, thank you! A couple of things regarding the format implementation in a separate file. It is good to follow the output format of the with the exception that descriptors are also returned, so 3 outputs. To create LAFs (kornia format for the local features), you can use function https://kornia.readthedocs.io/en/latest/feature.html#kornia.feature.laf_from_center_scale_ori where you feed all zeros instead of orientation and D2Net receptive field as a scale parameter. |
Hi Mihai, Did you have a chance to think about this, or do you need any help? |
Hi,
Would you be interested for porting the inference part of the D2Net into the kornia?
The idea is to allow simple usage of local features, like this:
We now have HardNet, SOSNet, TFeat and other descriptors.
It may also increase the usage of D2Net :)
The text was updated successfully, but these errors were encountered: