Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression between 1.8.2 and 2.0.0 #59

Closed
bhvngt opened this issue Aug 4, 2021 · 5 comments · Fixed by #60
Closed

Regression between 1.8.2 and 2.0.0 #59

bhvngt opened this issue Aug 4, 2021 · 5 comments · Fixed by #60

Comments

@bhvngt
Copy link

bhvngt commented Aug 4, 2021

When I upgrade to 2.0.0, I get following error

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/sandbox/node_modules/svelte-je
ster/src/svelteconfig' imported from /sandbox/node_modules/svelte-jester/src/transformer.js

Here's the sandbox where this error can be seen.

If I revert svelte-jester to 1.8.2, sandbox gives a different error but the same code works fine in my local system.

@sebastianrothe
Copy link
Collaborator

I have the same issue. Working on a fix.

@winfr34k
Copy link

winfr34k commented Aug 5, 2021

Hmm there still seems to be a bit of a problem. In our project, we still get stuff like this:

Jest: synchronous transformer .../node_modules/svelte-jester/src/transformer.js must export a "process" function.

Is this related or a separate issue?

@bhvngt
Copy link
Author

bhvngt commented Aug 5, 2021

@winfr34k you may want to refer to messages in this PR. You can also checkout this sandbox where its working as an ESM module in its glory with all kind of configurations :-)

@winfr34k
Copy link

winfr34k commented Aug 5, 2021

Thank you, @bhvngt!
However, we seem to still have incompatible dependencies (jest-mock-extended), so we can't switch just yet...

If anyone is interested in a diff to what's changed in our svelte/kit project, have a look here: https://github.com/communityvi/communityvi/pull/126/files

@sebastianrothe
Copy link
Collaborator

Hmm there still seems to be a bit of a problem. In our project, we still get stuff like this:

Jest: synchronous transformer .../node_modules/svelte-jester/src/transformer.js must export a "process" function.

Is this related or a separate issue?

You will get this error, if Jest thinks something does not use ESM. Could be Typescript or another transformer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants