Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocess to published files array #84

Merged

Conversation

sebastianrothe
Copy link
Collaborator

add preprocess to published files

Fixes #81

add preprocess to published files
@mihar-22
Copy link
Collaborator

Why did package-lock.json completely change? What version of NPM are you using? Prefer NPM >=7 to use v2 lockfiles. Is this related to something else? By the way maybe we should include the entire dist folder dist/?

@benmccann
Copy link
Collaborator

I agree that including the entire dist directory would be a better solution

@sebastianrothe
Copy link
Collaborator Author

sebastianrothe commented Sep 21, 2021

Why did package-lock.json completely change? What version of NPM are you using? Prefer NPM >=7 to use v2 lockfiles. Is this related to something else? By the way maybe we should include the entire dist folder dist/?

Well I am using the latest npm v7 and lockfile v2. Someone else committed an old lockfile before.

@sebastianrothe
Copy link
Collaborator Author

sebastianrothe commented Sep 21, 2021

@mihar-22 Please merge and publish a new version. I think this time it is correct :)

@sebastianrothe
Copy link
Collaborator Author

I agree that including the entire dist directory would be a better solution

I added one more commit.

@benmccann
Copy link
Collaborator

@mihar-22 it looks like you might be on npm 6. It got switched to the old lockfile format here: c59643a

Anyway, this looks good to me! Thanks for helping to work through these issues and get new versions out!

@benmccann benmccann merged commit 539f58c into svelteness:master Sep 21, 2021
@sebastianrothe
Copy link
Collaborator Author

Somehow the lockfile is v1 again. Is NPM doing this?

@mihar-22
Copy link
Collaborator

Ah I know why... I always try to run the tests but they fail on Node 16/NPM 7 due to SASS compiler not working with that version on the new ARMx64 architecture. So after that fails I switch to Node 14 and it works. It's the only way I can verify tests. I'll move releases to CI to resolve this, but we need to ensure commits follow standard semantic-release conventions, so probabaly need to add commitlint.

@sebastianrothe
Copy link
Collaborator Author

The tests do run in the CI, too.

But a release from the CI would be very nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module './preprocess.js'
3 participants