Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consistency] Trackers should copy URL to clipboard when icon is long-pressed #1087

Closed
4 tasks done
mm12 opened this issue Aug 6, 2024 · 4 comments · Fixed by #1101
Closed
4 tasks done

[Consistency] Trackers should copy URL to clipboard when icon is long-pressed #1087

mm12 opened this issue Aug 6, 2024 · 4 comments · Fixed by #1101
Labels
Feature request New feature or request

Comments

@mm12
Copy link
Contributor

mm12 commented Aug 6, 2024

Describe your suggested feature

When you long press a source, title, tracker title, and many other fields in the app, information is copied to the clipboard. Long-pressing tracker icons currently does nothing. I suggest that it copy the tracker URL to the clipboard.

Other details

I can probably implement this myself by the end of the week and open a PR. I'm not too experienced though so no guarantees.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.16.5.
  • I will fill out all of the requested information in this form.
@mm12 mm12 added the Feature request New feature or request label Aug 6, 2024
@mm12
Copy link
Contributor Author

mm12 commented Aug 7, 2024

It is unlikely it will happen this weekend because I will be on a road trip.
edit: started looking at it, app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt is what needs changing

@mm12
Copy link
Contributor Author

mm12 commented Aug 10, 2024

Well I forgot I never set up Android Studio on my new computer so yeah -_-

@AntsyLich
Copy link
Member

The thing is. Icon open browser is kind of a hidden feature. This become an ultra hidden feature 🫠

@mm12
Copy link
Contributor Author

mm12 commented Aug 10, 2024

I got it working, but need to resolve the issues with ktLintFormat not wanting to run, and that I forgot to revert some testing changes.

The version that has not been fixed is here: mm12@d3682d9

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants