Page indicator style is broken

[kidonng]

Steps to reproduce

1. Launch app
2. Open any manga
3. See issue

Expected behavior

0.16.4:

Actual behavior

0.16.5

Crash logs

No response

Mihon version

0.16.5

Android version

Android 13

Device

Redmi Note 10 Pro (chopin)

Other details

No response

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
• I have written a short but informative title.
• I have gone through the FAQ and troubleshooting guide.
• I have updated the app to version 0.16.5.
• I have updated all installed extensions.
• I will fill out all of the requested information in this form.

[Norsze]

It is not broken it is the new material design 3 elements from Google https://m3.material.io/components/sliders/overview

You'll have to live with it until they decide to change it again.

What is broken is the right to left reading slider being filled at page 1 though.

[Xori71]

It is not broken it is the new material design 3 elements from Google https://m3.material.io/components/sliders/overview

You'll have to live with it until they decide to change it again.

What is broken is the right to left reading slider being filled at page 1 though.

Actually, it does look broken.

The Material 3 slider has two sections, the active section, the inactive section, and a divider between the two. Meanwhile, Mihon has the active section, the divider, and... no inactive section. Furthermore, the slider looks overlayed on top of the dots representing the pages. My suggestion would be to completely get rid of the dots, and use the full slider. The steps would still be there, only the dots would disappear.

Edit: Or is this the issue?

[Norsze]

It's literally what I said. Check the left to right reading mode, it works as intended. The one that is broken is the right to left reading mode as that is now set by language

[Xori71]

It's literally what I said. Check the left to right reading mode, it works as intended. The one that is broken is the right to left reading mode as that is now set by language

Shit, my bad. I misread your reply.

[Norsze]

I wonder if this could be solved by reversing the colors? Like take this discrete slider and just reverse the colors on them? Or does that break the theming everywhere else?

[Xori71]

I wonder if this could be solved by reversing the colors? Like take this discrete slider and just reverse the colors on them? Or does that break the theming everywhere else?

I am not familiar with Material Design frameworks, but in this instance, the segment doesn’t appear at all in the slider. Reversing the colors would probably just make the slider grey.

[MajorTanya]

Some themes were created with a colour palette that doesn't 100% match with what Material Design expects. Sometimes, attributes that are expected to be visually different have historically been set to the same value, causing these newer component designs to end up using the same colour twice.

M3 colours palettes are defined by a long list of attributes, like primary and primaryInverse (I believe there are about 30 or so different attributes).

"Fixing" these colour sets by making the attributes these components use actually distinct would mean going back and trying to recreate every theme with the modern palette definitions. While this is technically possible, it would be painstaking work and also end up with most themes appearing differently (because of the newly differing colours).

Some themes intentionally define different attributes as the same colour to preserve the aesthetic of the theme, and would end up appearing extremely different if they defined their colours exactly to spec.

This affects several of these progress components across the app, not just the chapter slider.

[Xori71]

Some themes were created with a colour palette that doesn't 100% match with what Material Design expects. Sometimes, attributes that are expected to be visually different have historically been set to the same value, causing these newer component designs to end up using the same colour twice.

M3 colours palettes are defined by a long list of attributes, like primary and primaryInverse (I believe there are about 30 or so different attributes).

"Fixing" these colour sets by making the attributes these components use actually distinct would mean going back and trying to recreate every theme with the modern palette definitions. While this is technically possible, it would be painstaking work and also end up with most themes appearing differently (because of the newly differing colours).

Some themes intentionally define different attributes as the same colour to preserve the aesthetic of the theme, and would end up appearing extremely different if they defined their colours exactly to spec.

This affects several of these progress components across the app, not just the chapter slider.

So we basically have to pray that Google does something about this themselves.

[MajorTanya]

Some themes were created with a colour palette that doesn't 100% match with what Material Design expects. Sometimes, attributes that are expected to be visually different have historically been set to the same value, causing these newer component designs to end up using the same colour twice.

M3 colours palettes are defined by a long list of attributes, like primary and primaryInverse (I believe there are about 30 or so different attributes).

"Fixing" these colour sets by making the attributes these components use actually distinct would mean going back and trying to recreate every theme with the modern palette definitions. While this is technically possible, it would be painstaking work and also end up with most themes appearing differently (because of the newly differing colours).

Some themes intentionally define different attributes as the same colour to preserve the aesthetic of the theme, and would end up appearing extremely different if they defined their colours exactly to spec.

This affects several of these progress components across the app, not just the chapter slider.

So we basically have to pray that Google does something about this themselves.

They won't. They're using the palette attributes they say should be visually different but some themes don't define them to be such. The sections not being different colours is a design issue with most of Mihon's themes.

[Xori71]

Some themes were created with a colour palette that doesn't 100% match with what Material Design expects. Sometimes, attributes that are expected to be visually different have historically been set to the same value, causing these newer component designs to end up using the same colour twice.
M3 colours palettes are defined by a long list of attributes, like primary and primaryInverse (I believe there are about 30 or so different attributes).
"Fixing" these colour sets by making the attributes these components use actually distinct would mean going back and trying to recreate every theme with the modern palette definitions. While this is technically possible, it would be painstaking work and also end up with most themes appearing differently (because of the newly differing colours).
Some themes intentionally define different attributes as the same colour to preserve the aesthetic of the theme, and would end up appearing extremely different if they defined their colours exactly to spec.
This affects several of these progress components across the app, not just the chapter slider.

So we basically have to pray that Google does something about this themselves.

They won't. They're using the palette attributes they say should be visually different but some themes don't define them to be such. The sections not being different colours is a design issue with most of Mihon's themes.

Oh, okay-okay.

[okt-olgak]

Even without RTL/LTR issues, the following issues are still present:

• Progress bar does not exist until 1/6 through the manga
• Dividing line is too thick for page count
• Dividing line has big gaps on both sides, making some pages look like they don't fit in either "read" or "unread".
  
  

All of those issues are probably caused by the progress bar not being designed for 40 discrete stops. I think this just means this M3 Discrete progress bar is not fit for Mihon purposes.

[Xori71]

All of those issues are probably caused by the progress bar not being designed for 40 discrete stops. I think this just means this M3 Discrete progress bar is not fit for Mihon purposes.

This is not the case. Nevermind, the wording was bad. I meant that the “1/6th” issue isn’t limited to 40 points.

[MajorTanya]

works correctly with a small number of pages, so I don't think this is somehow Mihon's fault.

[Xori71]

works correctly with a small number of pages, so I don't think this is somehow Mihon's fault.

1/6th of the 4 pages would be ~0.6 pages. 2 pages is well beyond that, so of course it looks fine. Check what I sent.

[MajorTanya]

All of those issues are probably caused by the progress bar not being designed for 40 discrete stops. I think this just means this M3 Discrete progress bar is not fit for Mihon purposes.

This is not the case.

I'm not sure I understand what you mean by "This is not the case" here, to be honest.

[Xori71]

All of those issues are probably caused by the progress bar not being designed for 40 discrete stops. I think this just means this M3 Discrete progress bar is not fit for Mihon purposes.

This is not the case.

I'm not sure I understand what you mean by "This is not the case" here, to be honest.

It was a stupid reply. I thought about it some more, and yeah the wording was wrong. It’s a mix of Mihon sometimes cramping too many dots inside the progress bar, and Google not having the spacing dynamically change after a certain point threshold has been passed.

[MajorTanya]

FWIW, I tried checking the M3 spec for these new "Sliders" as these are actually called, but the specs don't talk about a maximum number of steps, or about not colouring anything before 1/6.

[Xori71]

FWIW, I tried checking the M3 spec for these new "Sliders" as these are actually called, but the specs don't talk about a maximum number of steps, or about not colouring anything before 1/6.

I see. And I agree, I would be surprised if this is how the new design functioned normally. I don't know what the cause of these issues is.

[FooIbar]

https://developer.android.com/jetpack/androidx/releases/compose-material3#1.3.0-alpha02

Fixed an issue with Slider and RangeSlider on RTL layout

https://developer.android.com/jetpack/androidx/releases/compose-material3#1.3.0-alpha03

Updated Slider and ProgressIndicator colors to follow the new Non-Text Contrast specs.