Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter page not updating when selecting filter params #893

Closed
6 tasks done
thecompassmaker opened this issue Jun 12, 2024 · 4 comments · Fixed by #940
Closed
6 tasks done

Filter page not updating when selecting filter params #893

thecompassmaker opened this issue Jun 12, 2024 · 4 comments · Fixed by #940
Labels
Bug Something isn't working

Comments

@thecompassmaker
Copy link

Steps to reproduce

Enter Browse tab
Select filterable source
Tap filter
Change any param

Expected behavior

changing any param should update the screen to reflect the selection

Actual behavior

param does not update

Crash logs

No response

Mihon version

r6723

Android version

android 13

Device

pixel 7 pro

Other details

the filter page does update when the filter is sent (when the filter button on the filter page is tapped) and before the results are returned. the results coming back from the source do appear to correct. it seems to be a visual bug as when a checkbox is double tapped and the filter is sent, the checkbox is in the same state as it was before sending the filter

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@thecompassmaker thecompassmaker added the Bug Something isn't working label Jun 12, 2024
@deeplyarnab
Copy link

So, I've found that the parameters with checkboxes do get updated but no visual confirmation is shown (for both whitelist & blacklist options).
Any text fields just don't work, be it typing or copy pasting.

@thecompassmaker
Copy link
Author

fwiw problem persists as of r6735

@amayra
Copy link

amayra commented Jun 21, 2024

out of curiosity, what libraries is to blame for this bug, or is this a developer mistake ?

i couldn't find commit by developer that may result of this bug

@FooIbar
Copy link
Contributor

FooIbar commented Jun 21, 2024

out of curiosity, what libraries is to blame for this bug, or is this a developer mistake ?

i couldn't find commit by developer that may result of this bug

Here 46003ec

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants