Skip to content

Commit 335d0be

Browse files
committed
changed include to render on simple compnents, updated readme with SSL cheat
1 parent f77445c commit 335d0be

File tree

7 files changed

+11
-7
lines changed

7 files changed

+11
-7
lines changed

config.yml.example

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ development:
99
store:
1010
storefront_api_key:
1111
directory: dist/
12+
# Note: when first deploying to a new theme you may have to comment out the ignore files.
13+
# Then after first upload uncomment them.
1214
ignore_files:
1315
- config/settings_data.json
1416
- "*.js"

readme.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ This project uses [TailwindCSS](https://tailwindcss.com/) `v2` a utility-first C
7777
In the event that you find the HMR assets are not loading and the requests to localhost:9000 are 404 you will need to approve or pass a valid certificate.
7878
To solve this issue you can open a new browser window and approve the SSL Certificate or pass a valid certificate as mentioned here [devServer.https](https://webpack.js.org/configuration/dev-server/#devserverhttps).
7979

80+
**Note:** a quick fix with Chrome `chrome://flags/#allow-insecure-localhost` change to enable
81+
8082
## HMR (Hot Module Reloading)
8183
When in development mode `yarn start` hot module reloading is enabled. It watches for changes to `JavaScript`, `CSS` and `Liquid` files. When JS or CSS is changes the browser will change without the need to refresh. When changes are made to liquid files a manual browser reload may be required.
8284

src/components/layout/theme.liquid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
{%- comment -%}Varibles{%- endcomment -%}
3232
{{ content_for_header }}
33-
{% include 'global-css' %}
33+
{% render 'global-css' %}
3434

3535
{{ 'tailwind.min.css' | asset_url | stylesheet_tag }}
3636
{{ 'bundle.global-css.css' | asset_url | stylesheet_tag }}

src/components/sections/header/header.liquid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
{%- for link in linklists[section.settings.menu].links -%}
3030
{%- if link.links != blank -%}
3131
<li class="inline-block mt-0 mr-4">
32-
<a href="{{ link.url }}">{{ link.title }}{%- include 'icon-arrow-down' -%}</a>
32+
<a href="{{ link.url }}">{{ link.title }}</a>
3333
<ul class="text-sm flex-grow">
3434
{%- for childlink in link.links -%}
3535
<li class="inline-block mt-0 mr-4"><a href="{{ childlink.url }}">{{ childlink.title }}</a>

src/components/sections/product/product.liquid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
</div>
5353
</div>
5454
<div class="mt-3 pb-5 border-b-2 border-gray-200 mb-5">
55-
{% include 'input-counter' %}
55+
{% render 'input-counter' %}
5656
</div>
5757
<div class="flex">
5858
<span

src/components/templates/collection.liquid

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
{%- if settings.pagination and paginate.pages > 1 -%}
2727
{%- comment -%}Pagination Control in Theme Settings{%- endcomment -%}
2828
{%- if settings.pagination_type == 'accessable_pagination' -%}
29-
{% include 'accessible-pagination' %}
29+
{%- render 'accessible-pagination' with { paginate: paginate} -%}
3030
{%- elsif settings.pagination_type == 'default_pagination' -%}
31-
{% include 'default-pagination' %}
31+
{%- render 'default-pagination' with { paginate: paginate} -%}
3232
{%- endif -%}
3333
{%- endif -%}
3434
{% endpaginate %}

src/components/templates/list-collections.liquid

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
{%- if settings.pagination and paginate.pages > 1 -%}
2727
{%- comment -%}Pagination Control in Theme Settings{%- endcomment -%}
2828
{%- if settings.pagination_type == 'accessable_pagination' -%}
29-
{% include 'accessible-pagination' %}
29+
{%- render 'accessible-pagination' with { paginate: paginate} -%}
3030
{%- endif -%}
3131
{%- if settings.pagination_type == 'default_pagination' -%}
32-
{% include 'default-pagination' %}
32+
{%- render 'default-pagination' with { paginate: paginate} -%}
3333
{%- endif -%}
3434
{%- endif -%}
3535
{%- endpaginate -%}

0 commit comments

Comments
 (0)