Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version tags are not pushed #45

Open
tobyjsullivan opened this issue Feb 14, 2022 · 2 comments
Open

Version tags are not pushed #45

tobyjsullivan opened this issue Feb 14, 2022 · 2 comments

Comments

@tobyjsullivan
Copy link

The docs mention that tags should be pushed to the repo automatically.

* Push a tag for the new version to GitHub.

We're currently not seeing any tags pushed to our private repo when the action runs. I don't see anything in the docs about special configuration for pushing repo tags. Am I missing some sort of configuration to get tags working?

I'm looking at the code, and it looks like this part is simply commented out. Is that right?

/*
const env = process.env
const remote = `https://${env.GITHUB_ACTOR}:${env.GITHUB_TOKEN}@github.com/${env.GITHUB_REPOSITORY}.git`
exec(`git push ${remote} --tags`)
*/

@kf6kjg
Copy link

kf6kjg commented Sep 8, 2022

Wow, looks like that was disabled as part of a debugging operation a longtime ago: 0cdb164

Of course the work-around is simple, just push the tags:

      - name: Publish
        uses: mikeal/merge-release@master
        # ... etc...

      - name: Push generated git tags
        run: |
          git push --tags

@alvarolorentedev
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants