Promise usage

[benjamingr]

Hi, thanks for the nice library!

In the code you create a resolvable() only to resolve it with an already existing promise which is not something you typically have to do.

You can use fetch as this.response, the setTimeout also isn't necessary as promises take care of reacting on the next tick anyway.

I'll write a PR to illustrate what I mean

[bsouthga]

I'm not sure about the original intent with the resolver pattern, but promises actually don't resolve on the next event loop turn -- they resolve on the next microtask: https://stackoverflow.com/questions/25915634/difference-between-microtask-and-macrotask-within-an-event-loop-context.

You can see this clearly by running the following code in node or the browser:

Promise.resolve().then(() => console.log(1));
setTimeout(() => console.log(2), 0);
Promise.resolve().then(() => console.log(3));
console.log(4);

Which should output

4
1
3
2

(edited to fix for extra .resolve())

[benjamingr]

I actually started with that (promisifying setTimeout and using a setTimeout(fn, 0)) but then I realized it was only deferred so things like setting options would work (the fetch must be dispatched after all the configuration is done - meaning waiting a microtick is plenty.

That said, neither Node.js nor the browsers actually makes any guarantees about the order of things, and it's possible for promise callbacks to run before or after timers. Node.js explicitly makes no such guarantee about scheduling - only best attempt.

[benjamingr]

Here's a reference btw nodejs/node#15081

[mikeal]

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀