Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require user authentication #7

Open
dsas opened this issue Aug 1, 2014 · 2 comments
Open

Don't require user authentication #7

dsas opened this issue Aug 1, 2014 · 2 comments

Comments

@dsas
Copy link

dsas commented Aug 1, 2014

Instajam always tries to pass an auth token, even if one doesn't exist. It would be nice if authentication was not required - the instagram API does not require it for all calls, the client_id can be passed instead.

A call to API.location.search generates this URL:
https://api.instagram.com/v1/locations/search?lat=53.23597&lng=1.42500&access_token=null&callback=instajam140685247595

Ideally if authentication isn't required it should generate this URL:
https://api.instagram.com/v1/locations/search?lat=53.23597&lng=-1.42500&callback=instajam140685247595&client_id=xxxxxx

@mikefowler
Copy link
Owner

Thanks for the note, @dsas. I've been addressing this flaw over in the multiple-instances branch. It's also a full-rewrite, albeit with the same API. It's mostly fully functioning, just pending additional tests to be written. Take a look and see if it suits your needs. Note that the documentation in the README hasn't been updated in that branch yet, but all the source files are here.

EDIT: Have a look at the tests to see how the initialization should be done now.

@dsas
Copy link
Author

dsas commented Aug 13, 2014

@mikefowler sorry for the slow response, I've had a quick try and it seems perfect, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants