MIME::Types usage bug?

[ioquatix]

mail/lib/mail/attachments_list.rb

Lines 97 to 100 in a217776

	# Have to do this because MIME::Types is not Ruby 1.9 safe yet
	if RUBY_VERSION >= '1.9'
	filename = filename.encode(Encoding::UTF_8) if filename.respond_to?(:encode)
	end

Seems like this shouldn't be necessary any more?

[ioquatix]

We are also discussing whether memory usage can be improved. 70% of memory required by a default setup of mail is simply by the mime-types gem. mime-types/ruby-mime-types#123

It seems a pity that this gem is well engineered to be memory efficient and yet it's not possible to use it without a huge overhead which for 99% of cases probably isn't even relevant.

[jeremy]

Seems like it, but we support a wide range of mime-types versions. Can we limit it to specific versions only?

[ioquatix]

Regarding the ruby code, have we checked that this is still a problem? What version of mime-types suffered this problem? I just saw this code when reviewing how mail uses mime-types. But I don't really know more than that.

[jeremy]

Switched to mini_mime #1059, #1060