-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address_lists_parser.rb requires a lot of memory (~30 mb) #1342
Comments
The Ragel Bitmap PR looks pretty promising. Doesn’t look like it affects performance. I tested with derailed and instead of 30 mb I’m seeing about 5mb. Which is a pretty significant improvement.
|
Well, it depends. For our helpdesk we use the mail gem for parsing incoming messages a lot. |
😅 Sorry for the duplicate issue spam. I was working with someone on derailed benchmarks and mis-remembered that somehow I had gotten away without the memory increase for https://www.codetriage.com. While it doesn't look like there is an obvious replacement (that satisfies all memory and speed requirements) it did generate some good discussion and eyeballs in #1343 whether any changes end up getting merged or not, there's some new techniques in there that i've not seen before.
It matters more for memory constrained implementations, FaaS and PaaS. Usually, there's a line somewhere and if you're over even a few mb, you'll still start to swap and incur enormous perf penalties. I certainly understand that for some absolute performance is important. I also understand that one of the goals of the project is to not have a c-extension dependency. Thanks for your time and maintenance! |
any workarounds for Rails , seeing the same: derailed output:
lockfile fragments:
|
Loading the
address_lists_parser.rb
is the cause for about 1/3 of the startup memory for CodeTriage.It looks like it is generated by a parser generator Is there some way we can reduce that memory overhead?
The text was updated successfully, but these errors were encountered: