Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers are too big #1393

Closed
ahorek opened this issue May 22, 2020 · 2 comments
Closed

parsers are too big #1393

ahorek opened this issue May 22, 2020 · 2 comments

Comments

@ahorek
Copy link
Contributor

ahorek commented May 22, 2020

Ragel needs a new state for each possible character.

removing this parser would reduce the size by half
https://github.com/mikel/mail/blob/master/lib/mail/parsers/rfc3629_utf8.rl#L18

I think there's an opportunity to optimize this, perhaps replace it with a function? Thoughts?

see also #1343

@jeremy
Copy link
Collaborator

jeremy commented Jun 5, 2020

Open to experimentation!

@mikel
Copy link
Owner

mikel commented Apr 26, 2022

@ahorek go for it!

@mikel mikel closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants