Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxLines default value #32

Open
jasbindar-singh opened this issue May 23, 2022 · 1 comment · May be fixed by #41
Open

maxLines default value #32

jasbindar-singh opened this issue May 23, 2022 · 1 comment · May be fixed by #41

Comments

@jasbindar-singh
Copy link

Problem: I have a use case where I want to show the whole string when the user clicks on Show More cta but maxLines prop default value caps it to 8 lines.
Temporary solution: I have a huge value on maxLines prop for now to fix that but it somehow seems very hacky
Question: Is there any other way I could achieve that like without having to specify a huge number for maxLines prop value

@lagroms
Copy link

lagroms commented Apr 6, 2023

Agreed have the same issue. This prop should be optional. @mikelpmc

I've submitted a PR for this fix

@lagroms lagroms linked a pull request Apr 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants