Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: DbSettingMapper adds DbConnection instead of TDbConnection #756

Closed
tommasobertoni opened this issue Feb 2, 2021 · 0 comments · Fixed by #757
Closed

Bug: DbSettingMapper adds DbConnection instead of TDbConnection #756

tommasobertoni opened this issue Feb 2, 2021 · 0 comments · Fixed by #757
Assignees
Labels
bug Something isn't working

Comments

@tommasobertoni
Copy link
Contributor

Bug Description

I'm using the generic Add<TDbConnection> overload of DbSettingMapper:

DbSettingMapper.Add<MyDbConnection>(dbSettings, true);

class MyDbConnection : DbConnection ...

Exception Message:

RepoDb.Exceptions.InvalidTypeException:
    'Type must be a subclass of 'System.Data.Common.DbConnection'.'

The problem:

The method is using StaticType.DbConnection instead of typeof(TDbConnection), so then the Guard check fails because: DbConnection is not a subclass of DbConnection.

Workaround:
Use the non-generic overload:

DbSettingMapper.Add(typeof(DbConnectionHolder), dbSettings, true);

Library Version:

RepoDb v1.12.6 and RepoDb.MySql v1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants