Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: F# - Consider the Anonymous Types in the Query and QueryAll operation #536

Closed
mikependon opened this issue Sep 1, 2020 · 5 comments
Assignees
Labels
deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed. request A request from the community. todo Things to be done in the future

Comments

@mikependon
Copy link
Owner

In C#, there is no way to inferred the anonymous types within the generic type argument when calling the generic methods (i.e: ExecuteQuery<TEntity>(SQL), Query<TEntity>(tableName),QueryAll<TEntity>(tableName) and QueryMultiple<T1, T2, ..., T7>).

However, in F# the call is possible. See the screenshot below, provided by @isaacabraham.

Working Call:

image

Non-working Call:

image

This User Story will enable the library to consider the support to the Anonymous Types (or Anonymous Records) when calling the mentioned method above.

@mikependon mikependon added todo Things to be done in the future request A request from the community. labels Sep 1, 2020
@mikependon mikependon self-assigned this Sep 1, 2020
@mikependon
Copy link
Owner Author

Note: First screenshot works. Second one fails with "Value cannot be null (Parameter 'source')".

@mikependon
Copy link
Owner Author

The fix is now available at RepoDb v1.12.0-beta2.

@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Sep 2, 2020
@AngelMunoz
Copy link

Glad this was quickly implemented
I just tested it seems to work like a charm
image

I'll let you know if I find any issues, also I'll try to send a PR to the F# sample later today with precisely this change

@mikependon
Copy link
Owner Author

@AngelMunoz - thanks! Yes, please do comments all the problems you found during your penetration tests on this User Story.

@mikependon mikependon unpinned this issue Sep 2, 2020
@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Sep 4, 2020
@mikependon
Copy link
Owner Author

Closing this ticket now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed. request A request from the community. todo Things to be done in the future
Projects
None yet
Development

No branches or pull requests

2 participants