Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #257 #279

Merged
merged 2 commits into from
Nov 23, 2014
Merged

Fixes Issue #257 #279

merged 2 commits into from
Nov 23, 2014

Conversation

josh-padnick
Copy link

Per #257, the headers_more_module failed to compile due to simple path issues. This fixes that. I also updated the default headers_more_module to the latest version 0.25.

Fixes Issue sous-chefs#257
47eaca1 
- headers_more_module failed to compile due to simple path issues.
This fixes that.
@josh-padnick josh-padnick mentioned this pull request Oct 3, 2014
Closed
@josh-padnick
Copy link
Author

@miketheman This ok to merge? Would be great if we could pull our Nginx cookbook from GitHub instead of our own custom fork since we rely on this fix. Thanks.

@miketheman
Copy link
Contributor

@josh-padnick thanks for the contribution - any chance of adding some testing for this case?
We're trying to minimize new features in favor of bug fixing and testing before releasing a new version, as per the roadmap file in the root of the repo.

@josh-padnick
Copy link
Author

@miketheman Sure, I'd be happy to add some tests. Can you point me to what you think is the best example code to copy from? Also, this isn't a feature-add; it's a bug-fix for #257 .

@miketheman miketheman added the bug label Oct 16, 2014
@rtgibbons
Copy link

Another bump to get this merged it, as it's failing to work as it stands right now.

@miketheman miketheman merged commit 2548a69 into sous-chefs:master Nov 23, 2014
miketheman added a commit that referenced this pull request Nov 23, 2014
@miketheman
remove extra commands from headers_more, tests
ec86d0e 
The mv/rm lines in the headers_more module are no longer used.

- Add ChefSpec tests
- Add Test Kitchen tests

Refs #279
Closes #227, #257
@miketheman miketheman added this to the 2.7.5 milestone Nov 23, 2014
@miketheman miketheman self-assigned this Nov 23, 2014
@miketheman
Copy link
Contributor

Thanks @josh-padnick ! I added tests and some cleanups.

@miketheman miketheman mentioned this pull request Nov 23, 2014
Closed
@miketheman miketheman mentioned this pull request Mar 15, 2015
Closed
@tas50 tas50 removed the bug label Jan 25, 2019
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.
4 participants
@josh-padnick @miketheman @rtgibbons @tas50