[danbooru] add option for extended metadata extraction #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikf
reviewed
Apr 12, 2021
There was a problem hiding this comment.
I'm wondering if it would be somehow possible to include this extra metadata in regular API calls, i.e. without the extra request per post. I couldn't figure it out for ugoira metadata, but there aren't too many of those. Here it would essentially be an N+1 query problem.
Co-authored-by: Mike Fährmann <mike_faehrmann@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to danbooru to get additional metadata about notes, artist commentary, parent and children at the cost of one additional API request.