Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hentaicosplays] Add extractor #1473

Merged
merged 2 commits into from
Apr 18, 2021
Merged

[hentaicosplays] Add extractor #1473

merged 2 commits into from
Apr 18, 2021

Conversation

hanscg
Copy link
Contributor

@hanscg hanscg commented Apr 16, 2021

Hi, this is my first contribution.
This was requested but the issue seems to have been closed (#907)

https://hentai-cosplays.com have two sister sites which work exactly the same but contain different contents.
I put them in one extractor for now.
If it's better to split them into 3 I'll be glad to work on it.
Cheers.

@mikf mikf merged commit 334d690 into mikf:master Apr 18, 2021
mikf added a commit that referenced this pull request Apr 18, 2021
@mikf
Copy link
Owner

mikf commented Apr 18, 2021

Thank you! You could've used GalleryExtractor as base class, so you wouldn't have to manually write an items() method and deal with Messages, etc. (dddda7d)

@hanscg hanscg deleted the hentai-cosplays branch April 20, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants