New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the "real" minimum cmake version in CMakeLists.txt #277

Closed

jonesmz opened this issue Feb 5, 2022 · 1 comment

Labels

build

jonesmz commented Feb 5, 2022

The github actions CI is using Ubuntu 20.04, and Mac OS X 11, both of which come pre-installed with
Cmake 3.22.2
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md

But the CMakeLists.txt is set to the minimum version of

cmake_minimum_required(VERSION 3.1)

I recommend determining what the oldest platform you think you want to support is, and picking the CMake version from that platform.

mikke89 added the build label

Owner

mikke89 commented Feb 6, 2022

Thanks, this is probably a good idea indeed. However I will defer this to #198 and let it be a part of that work.

mikke89 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment