Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dip_polish branch to mainstream #695

Open
mp15 opened this issue Apr 11, 2024 · 3 comments
Open

Merge dip_polish branch to mainstream #695

mp15 opened this issue Apr 11, 2024 · 3 comments

Comments

@mp15
Copy link

mp15 commented Apr 11, 2024

Hi,

I've been using hapdup (https://github.com/KolmogorovLab/hapdup) and was looking at how it was put together (I'm interested in using it with chromothriptic genomes and I want to modify it for CN=1 regions) and noticed it is based on your dip_polish branch rather than main. I was wondering what the reasoning in abandoning dip_polish was? Do you recommend just flat filtering reads to HP=[1|2] instead with samtools view -d HP=1 or something else? Also I notice there was INDEL cluster code that didn't make it to main? I assume it didn't perform well?

@mikolmogorov
Copy link
Owner

Hello,

dip_polish is indeed currently used in Hapup - so it is not abandoned.

@mp15
Copy link
Author

mp15 commented Apr 12, 2024

Thanks for getting back so quick. That's awesome, any plans to merge it to master or is there a compromise in using the INDEL cluster method? Developing against a special purpose branch always kinda makes me nervous. I'm happy to do the work on a pull request to get it resynced if time is an issue.

@mikolmogorov
Copy link
Owner

Sorry for the late response - we do plan to merge eventually. But this is not the priority currently, so I can't tell you exactly when this would happen..

@mikolmogorov mikolmogorov changed the title Abandoned dip_polish branch? Merge dip_polish branch to mainstream Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants