-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle subfolder based translations [feature] #61
Comments
I´m waiting for that solution also. I asked Mikrobi about the Babel 2.3 version but i had no reply about that!!! :( |
Just to clarify: I'm willing to help develop that solution. It would be great to have an idea of what's planned rather than going off and coding something completely different... |
Yes, i agree!!! I think a folder based solution it´s more than welcome... i think it´s essencial!! But i think he is developing Babel in that way... i don´t know!!! Unfurtunetly i´m not coder so i can not help developing this feature!!! :( |
Hi, As far as i know Jakob is really busy. |
Excelent job!!!! Amazing!!!! Much more user friendly!!!! :) |
I now have a rough working version of this. Works with one context containing multiple language folders, and falls back to the default 'one context per language' behaviour if subfolders are not specified. This is handled simply by adding the language folder to the contextKeys configuration. Eg: This is for a client project so that takes priority but I'll look at getting some properly tested and polished code up here in the next few weeks. Hopefully :) |
Excelent!!!! Exactly what i need!!!! :) :) |
@rtripault: I'll be testing your changes on a small but 5-language site I'm working at. @lucasmodx: Could you share your changes in your fork? I don't know whether that has been asked before: shouldn't the plugin, which handles context switching based on language be part of a more general solution? I mean, there are "context router" and "gateway manager" (plus "domaineer") which all handle the job already. Wouldn't be better to extend them to handle multi-language setups? Or maybe they already do support them (haven't tested)? From the first look "domaineer" seems to be able to handle the single-context/multi-domain scenario out-of-the-box. I guess it could be configured to handle single-context/subfolders scenario too. My point is not to duplicate parts of functionality but extend what is available already and can work in more general way fitting into the ecosystem. My 2c. |
@gadamiak my fork isn't up to date. You might want to add the MODX package provider https://extras.melting-media.com/ to get the last build (i'm currently using it on a project and a pull request will be sent to the original repository once the work will be more polished). Feel welcome to report any bug and/or give feedback (preferably on my fork) |
@Romain Thanks for update! I'll definitely give it a try and report back. |
@lucasmodx: Could you share your Babel´s version? I´m really interested on it!!! :) |
@rtripault – just checked out your vid – looks excellent. Are you pushing to merge or going to keep a fork? |
@shaunmorrison Thanks. A pull request is definitely something planned. The biggest problem being to find some time to :) |
@rtripault: Nice video, well done! Unfortunately no audio. What happened to "syncronize TV's" when linking? |
@manu37 you don't want to ear my English skills (hence the "no audio"). Also this video (almost one year old by now) was made while i was coding a Proof of Concept. Since then the "sync TVs" feature jumped in and you no more need to manually specify the context key. All in all, i got the feeling i'm hijacking the original issue (that was not the purpose). Feel free to comment on my "fork" instead |
@lucasmodx I would be very interested in your rough solution. Are you willing to share code or at least logistical direction on how to do it. I to as did you need it now and cant wait for 2.3 |
Don't want to look like I'm ignoring this (as that's how I felt re: the original author), however I really don't have enough time to pull the bits together just right at this moment. Give me a nag after the weekend and I'll at least try to upload some code for you to have a look at. It probably won't work without some mods, but might be a good starting point. |
No problem or rush. Thanks fro getting back to me. Best Regards, Adam Smith Please consider the environment before printing this e-mail On Feb 14, 2013, at 10:47 AM, lucasmodx notifications@github.com wrote:
|
It's coming. |
I'm hoping to open up some discussion regarding taking Babel to 2.3 as discussed at the end of this article:
http://www.multilingual-modx.com/blog/2011/seo-friendly-multilingual-websites-with-modx-and-babel.html
I'm developing a network of sites all managed within one MODX install, with languages to be handled both via Context switching for single-language domains (such as domain.nl), and subfolder switching within a single Context for multi-language domains (such as domain.com/en, domain.com/fr). For this case, Contexts represent unique domains.
I'm about to to modify Babel to achieve this myself as I need the functionality for a current project. It would however be great if what I do moves in the same direction as what you intend to implement for 2.3, and of course any code I generate may be used as a contribution to Babel. Could we share ideas on how you were planning to move this forward?
If you would prefer to continue this discussion on the MODX forums or elsewhere, just let me know.
Cheers
Luke
The text was updated successfully, but these errors were encountered: