Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new function that runs the setup of structure S #177

Merged
merged 4 commits into from
May 14, 2024

Conversation

swilliamson7
Copy link
Collaborator

If you're not opposed to this I added a function that sets up and returns S but doesn't do any integrating, I use it to start my Enzyme runs

@milankl
Copy link
Owner

milankl commented May 13, 2024

Sounds great, yeah I mean this is where the run_model interface is falling apart because as you clearly say one does need a way to set all parameters for a model configuration, then have access to the (i.e. one single) model/simulation object and then a way to run that simulation forward. That's why we do that in SpeedyWeather. Glad you're suggesting the same!

@milankl
Copy link
Owner

milankl commented May 13, 2024

What about calling run_setup instead model_setup as it creates a ModelSetup and returns it?

@swilliamson7
Copy link
Collaborator Author

Sounds great, easy to remember! I'll merge it after the checks complete

src/run_model.jl Outdated Show resolved Hide resolved
src/run_model.jl Outdated Show resolved Hide resolved
@swilliamson7 swilliamson7 merged commit 87156f6 into main May 14, 2024
4 checks passed
@swilliamson7 swilliamson7 deleted the sw/setup-function branch May 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants