Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Cargo.lock file #191

Closed
DanielNoord opened this issue Dec 11, 2024 · 2 comments · Fixed by #192
Closed

Add a Cargo.lock file #191

DanielNoord opened this issue Dec 11, 2024 · 2 comments · Fixed by #192

Comments

@DanielNoord
Copy link

For #148 it seems some Cargo.lock files were removed, but with the new project structure of >= 2.9.x there is no longer a Cargo.lock file anywhere within the project.
This actually makes the package quite hard to package on downstream packagers as those tend to require a lock file.

See the relevant section in the nix guidelines:
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md

Would it be possible to add a top-level Cargo.lock file again and do a release so we could package a version that supports Python 3.13 but is also packagable by the default infrastructure in nix?

@milesgranger
Copy link
Owner

Released v2.9.1
Thanks for informing me about this.

@DanielNoord
Copy link
Author

Awesome, appreciate the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants