Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add hi (Hindi) language. #165

Merged
merged 3 commits into from
Oct 6, 2023
Merged

new: Add hi (Hindi) language. #165

merged 3 commits into from
Oct 6, 2023

Conversation

sudipshil9862
Copy link
Contributor

adding hindi language support for gtkemojichooser

@sudipshil9862 sudipshil9862 changed the title Add hi (Hindi) new: Add hi (Hindi) language. Oct 5, 2023
@sudipshil9862
Copy link
Contributor Author

@milesj please review my PR. all checks have passed

Copy link
Owner

@milesj milesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was packages/data/en/shortcodes/joypixels.raw.json deleted?

@@ -40,6 +40,7 @@ jobs:
strategy:
matrix:
locale:
- hi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you alphasort this, and in the other files too


msgctxt "LABEL: Very short word for skin tone and/or color (max 1 word if possible)"
msgid "tone"
msgstr ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these need to be translated

@sudipshil9862
Copy link
Contributor Author

@milesj please review my PR. all checks have passed

@sudipshil9862
Copy link
Contributor Author

@milesj please merge it if everything is fine as I need to make PR on gtkemojichooser

@milesj
Copy link
Owner

milesj commented Oct 6, 2023

Awesome

@milesj milesj merged commit ada3784 into milesj:master Oct 6, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants