Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing implicit annotations. #123

Open
milessabin opened this issue Jun 25, 2014 · 5 comments
Open

Add missing implicit annotations. #123

milessabin opened this issue Jun 25, 2014 · 5 comments

Comments

@milessabin
Copy link
Owner

There are very many implicit arguments in shapeless without @implicitNotFound annotations. Adding them would make compiler errors more readable.

@ceedubs
Copy link
Collaborator

ceedubs commented Jul 12, 2014

@milessabin does this issue refer to explicitly annotating the return types of implicit vals and defs or to adding @implicitNotFound annotations to type classes?

@milessabin
Copy link
Owner Author

@ceedubs description updated.

@milessabin
Copy link
Owner Author

Partially addressed in #239 ... lots more to do.

@joroKr21
Copy link
Collaborator

joroKr21 commented May 9, 2017

What would be a good template for the error messages? I'm thinking something like this:

Implicit not found: TypeClass[A, B, C].
Could not prove / compute / infer whatever type lever operation with A, B and C.

Then the question is whether to keep it short (a 2-lliner) or try to elaborate possible causes / solutions e.g: "Try to use the Aux pattern", "Make sure your Poly has the right arity", etc.

@milessabin
Copy link
Owner Author

I think the messages should be specific to the particular type class in question ... I'm not sure that replacing the existing default message with a similarly non-specific template would be all that much of an improvement.

@joroKr21 joroKr21 modified the milestones: shapeless-2.4.0, shapeless-2.5.0 Mar 16, 2020
@joroKr21 joroKr21 removed this from the shapeless-2.5.0 milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants