Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive images not being generated #142

Closed
dottodot opened this issue Jun 19, 2021 · 2 comments · Fixed by #144
Closed

Responsive images not being generated #142

dottodot opened this issue Jun 19, 2021 · 2 comments · Fixed by #144
Labels
bug Something isn't working
Milestone

Comments

@dottodot
Copy link

I had this issue in my test app but have also tried using your example just to make sure, but the image component isn't generating the various image sizes. Even though the width query param is present the original image size is always returned.

I've also noticed that _next/image has not been created in the bucket.

@ofhouse
Copy link
Member

ofhouse commented Jun 19, 2021

Yes, we had an issue in the image optimizer that prevented the optimization to work properly: milliHQ/terraform-aws-next-js-image-optimization#44

It's already fixed. But we released it as major version v11.0.0 and therefore the version constraint (~> 10.0.8) in the main.tf does not allow to upgrade to the latest version:
https://github.com/dealmore/terraform-aws-next-js/blob/dd5b61321e9b2bf3e8b56e418ae3700e812007f3/main.tf#L153-L157

I will publish a new release soon that increases the version constraint, which should fix the issue.

The image optimizer does not use a S3 bucket to store the processed images, instead the images are stored in CloudFront Origin Shield (which provides a similar caching behavior).
For more information see the repository of the image optimization module: https://github.com/dealmore/terraform-aws-next-js-image-optimization

Again thanks for reporting!

@ofhouse ofhouse added the bug Something isn't working label Jun 19, 2021
@ofhouse ofhouse added this to the v0.10.0 milestone Jun 19, 2021
@ofhouse
Copy link
Member

ofhouse commented Jun 20, 2021

This is now fixed in the v0.9.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants