Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nodejs16.x runtime #316

Closed
ofhouse opened this issue May 16, 2022 · 3 comments
Closed

Support for nodejs16.x runtime #316

ofhouse opened this issue May 16, 2022 · 3 comments
Labels
upstream/terraform Waits for implementation in Terraform
Milestone

Comments

@ofhouse
Copy link
Member

ofhouse commented May 16, 2022

ToDo:

@ofhouse ofhouse added the upstream/terraform Waits for implementation in Terraform label May 16, 2022
@ofhouse ofhouse added this to the v0.13.0 milestone May 26, 2022
@ofhouse ofhouse closed this as completed May 28, 2022
@larahroth
Copy link

Hi! :D We are using your lovely library and noticed that edge functions now support node 16.

However I think setting the "engines": { "node": "14.x" } field in your package.json is the right solution here.
The CLI should still build fine with Node.js 16, but since we currently don't support the nodejs16.x runtime, it does not make sense to allow the creation of Lambdas with Node.js 16 as target.

Are we able to look into supporting node 16? Node 14 is significantly out of date at this point, especially with the version of npm it ships with. Let me know if you need help with anything on this, happy to help.

Thank you in advance! @ofhouse :D

@ofhouse
Copy link
Member Author

ofhouse commented Sep 22, 2022

Hey @nyt-larahelenaroth,

didn't noticed yet that Node.js 16 runtime was released to Lambda@Edge as well. Thanks for the reminder.

Upgrading should only have a small impact since it is only used by the router module.
The Next.js functions itself run on standard Lambdas that already support Node.js 16.

@larahroth
Copy link

@ofhouse Amazing! Thank you so much for replying & so glad to hear :D Please let us know timing so we can adjust once the support is deployed. Exciting news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/terraform Waits for implementation in Terraform
Projects
None yet
Development

No branches or pull requests

2 participants