Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with external CloudFront resource #55

Closed
1 task done
ofhouse opened this issue Feb 14, 2021 · 1 comment · Fixed by #134
Closed
1 task done

Use with external CloudFront resource #55

ofhouse opened this issue Feb 14, 2021 · 1 comment · Fixed by #134
Labels
feature/terraform Missing feature from Terraform
Milestone

Comments

@ofhouse
Copy link
Member

ofhouse commented Feb 14, 2021

Currently the main CloudFront resource is created & managed by the module itself.
While this is great as a quick setup for new users, it can become difficult for advanced use cases to integrate the module into an existing setup.

So we should switch to a similar approach as we did on the image optimizer module:

  • Create a managed CloudFront distribution by default (Quick setup)
  • Prevent creation of CloudFront distribution and export all configuration (Cache & Origin Policies), so that it can be integrated into an existing CloudFront Distribution

ToDo

  • Rework Custom Domain Example to use external CloudFront distribution
@chamilad
Copy link
Contributor

Thanks for introducing this feature! In my case I found that certain changes (ex: resource names) could recreate CF distribution and I have to update naming manually each time my pipeline runs. This decoupling helps to keep that constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/terraform Missing feature from Terraform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants