Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored sliceutil breaks with go modules #18

Closed
mgilbir opened this issue Dec 10, 2018 · 2 comments
Closed

Vendored sliceutil breaks with go modules #18

mgilbir opened this issue Dec 10, 2018 · 2 comments

Comments

@mgilbir
Copy link
Contributor

mgilbir commented Dec 10, 2018

When go getting the package in a project using go modules in go1.11, I get:

$ go get "github.com/milochristiansen/lua"
go: finding github.com/milochristiansen/lua v1.1.6
go: downloading github.com/milochristiansen/lua v1.1.6
go build sliceutil: no Go files in

When building, the error is cannot find module for path sliceutil

Possible solutions would be, bringing the sliceutil package into the project (out of the vendor directory), or if sliceutil is meant to be an external dependency it could be made available in another repo.

@milochristiansen
Copy link
Owner

Yeah, that package is a lazy hack I pulled in from some of my private code. I should either integrate it properly or just redo the places that use it to be less hacky.

One way or another it will be gone either today or tomorrow.

@mgilbir
Copy link
Contributor Author

mgilbir commented Dec 10, 2018

Wow. Thanks for the quick fix! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants