Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Change Has_XXX functions into Describe_XXX #70

Open
1 task done
jiaoew1991 opened this issue Oct 17, 2023 · 4 comments
Open
1 task done

[Feature]: Change Has_XXX functions into Describe_XXX #70

jiaoew1991 opened this issue Oct 17, 2023 · 4 comments
Labels

Comments

@jiaoew1991
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

All of the Milvus API changed, the Has_XXX functions will be deprecated in the future version

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@jiaoew1991 jiaoew1991 assigned yah01 and unassigned yah01 Oct 17, 2023
@Smartmind12
Copy link

Hey @jiaoew1991 When i searched has_ funtions there are 1.1 K files in the master repo mentioning the function...so could you help me which ones need to be changed?

@jiaoew1991
Copy link
Author

Hey @jiaoew1991 When i searched has_ funtions there are 1.1 K files in the master repo mentioning the function...so could you help me which ones need to be changed?

@yah01 Could you help @Smartmind12 point out what needs to be changed

@yah01
Copy link
Member

yah01 commented Oct 26, 2023

Hi @Smartmind12, the Milvus server deprecated the HasXxx APIs, the SDK would keep the API but change the impl, like has_collection method in src/client.rs, it calls the HasCollection API of Milvus Server, we need to change it to call DescribeCollection API.

I just checked, only has_collection in src/client.rs and has_partition in src/collection.rs need to be changed

@Smartmind12
Copy link

Hi @Smartmind12, the Milvus server deprecated the HasXxx APIs, the SDK would keep the API but change the impl, like has_collection method in src/client.rs, it calls the HasCollection API of Milvus Server, we need to change it to call DescribeCollection API.

I just checked, only has_collection in src/client.rs and has_partition in src/collection.rs need to be changed

Thanks and I understand and will do the needful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants