Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5] support to deny dll according to database property #40784

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/L Denotes a PR that changes 100-499 lines. labels Mar 19, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Mar 19, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (14259a3) to head (bd5d4ac).
Report is 10 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/rootcoord/quota_center.go 94.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40784      +/-   ##
==========================================
- Coverage   80.93%   80.90%   -0.03%     
==========================================
  Files        1419     1420       +1     
  Lines      202006   202079      +73     
==========================================
+ Hits       163489   163500      +11     
- Misses      32827    32871      +44     
- Partials     5690     5708      +18     
Components Coverage Δ
Client 79.87% <ø> (+0.09%) ⬆️
Core 70.55% <ø> (-0.02%) ⬇️
Go 82.79% <94.73%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/simple_rate_limiter.go 86.13% <100.00%> (+0.17%) ⬆️
internal/util/ratelimitutil/rate_limiter_tree.go 95.54% <100.00%> (+0.09%) ⬆️
pkg/common/common.go 78.48% <ø> (ø)
internal/rootcoord/quota_center.go 83.46% <94.00%> (+0.46%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 19, 2025
@mergify mergify bot removed the ci-passed label Mar 20, 2025
Copy link
Contributor

mergify bot commented Mar 20, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Mar 20, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 20, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Mar 20, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 20, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Mar 21, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 21, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1263505 into milvus-io:2.5 Mar 23, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. go Pull requests that update Go code kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants