Skip to content

Latest commit

 

History

History
127 lines (99 loc) · 7.81 KB

20201124-meeting-development.md

File metadata and controls

127 lines (99 loc) · 7.81 KB

Meeting Notes: Development, Nov 24 2020

Development meeting held @ 3PM UTC in grincoin#dev channel on Keybase. Meeting lasted ~ 90 min.

Notes are truncated, and conversations sorted based on topic and not always chronological. Quotes are edited for brevity and clarity, and not always exact.

Community attendance:

  • antiochp
  • cekickafa
  • jaspervdm
  • joltz
  • lehnberg
  • phyro
  • quentinlesceller
  • tromp
  • yeastplume
  • vegycslol

(apologies if I missed someone - submit a PR or contact @lehnberg to add)

Agenda points & Actions

1. Retrospective

  • antiochp: Been doing a lot of merging and integration of PRs. Still a few to review and merge, but I think everything is looking good.

2. Agenda review

The proposed agenda was reviewed and "accelerating development" was added as was requested in an agenda comment.

3. Action point follow ups from previous meetings

3.1 Slatepack comms

  • joltz:_ We have reached out to all known points of contact for services. The ball is in their court at this point. It is always good to remind and encourage in further interactions as possible.
    • 💪: antiochp, phyro, cekickafa, dtavarez
  • lehnberg: I am in progress of confirming, but an exchange might be in need of some assistance with debugging and integration help. If people are interested, they can ping me. I can share more info once the exchange confirms they are okay with that
    • 👍: antiochp, joltz, cekickafa, dtavarez
  • cekickafa: Users should put pressure to exchanges as well. They should be demanding slatepacks.
    • 👍: antiochp
    • antiochp: Yes that's a good point - it's kind of up to everyone involved to be pushing this and nudging them in the right direction. Nobody needs to wait for Grin to be doing this through "official" channels.
      • 💯: cekickafa

3.2 Testnet mining

  • antiochp: Looks like its producing blocks on a regular basis right now. Not sure how many gpus are running against testnet but it's running.
  • tromp: With TESTNET_FOURTH_HARD_FORK: u64 = 642_240, we are expected 14.2 days from testnet HF4 , which lands right on dec 8.
    • 🚀: antiochp, phyro, jaspervdm, joltz, cekickafa, lehnberg

3.3 Reorg status

  • antiochp: Any updates or anything to report here?
    • lehnberg: There's grindefender.online.
    • We still have the banner up on the website that should be changed
    • joltz: We still have the banner up on the website that should be changed
    • lehnberg: Good shout let's get that done by the end of this meeting.
  • joltz: If anyone missed it, joltz.keybase.pub/api/grin shares current network health status including reorg info. values are generated from https://github.com/j01tz/grin-health
    • 👏: phyro
  • antiochp: Nice use of a keybase url for the api there!
    • joltz: Thanks, I'll eventually move it to something more generic and not my personal account. But I think @mcmmike is planning to add the score API into his infrastructure so will have something a little better hopefully.
  • antiochp: Good stuff, sounds like things are progressing there.
    • joltz: Ideally we have something dynamic with website where warning banner appears when score <=2 or something but can do it manually for now.

4. v5.0.0 status

  • lehnberg: #287

    https://github.com/orgs/mimblewimble/projects/1

  • antiochp: Fix DAA @tromp, I think people owe you some reviews?

    • tromp: Yep, I updated fixfees PRs yesterday to be able to handle huge fees before HF4.
    • antiochp: Want to fix conflicts in DAA one? There's been a lot of merges past few days.
    • tromp: Didn't notice conflicts yet. But will have a look after meeting.
  • antiochp: Fix Fees - I need to take another look and review - anyone else feel free also, the more eyes the better.

    • 👀: jaspervdm
    • tromp: Am also writing some separate huge_fees test files in the style of nrd_kernels_{dis,en}abled.rs. But that's just icing on the cake. fixfees is ready for review.
  • antiochp: Header version is good to go I think - late locking is done and merged. ✅

    • grinparrot: phyro, cekickafa, quentinlesceller
  • antiochp: Deprecate https, where are we with that one?

  • antiochp: Oh probably worth kicking off tests again on any PR with tests failing - we had some issues with windows builds on CI.

    • jaspervdm: Yeah we also need to update CI on grin-wallet, will do after meeting.
    • antiochp: CI fix here for reference.
  • antiochp: PIBD - couple of PR merged, 1 to go I think?

    • jaspervdm: Yes one that needs to be reviewed. Plus I think we should turn the PIBD p2p flag on by default as well in a separate PR.
    • antiochp: Yes - I can grab the flag one @jaspervdm.
      • 👍: jaspervdm
    • joltz: Will review that as well. I just saw a bunch of email from github from reviews you requested in my spam. :(
    • antiochp: Ok I'll merge the v5 header PR after this meeting and I'll update the tracking issue for that and I'll grab the p2p msg flag PR (small change to enable by default) and hopefully we get "fees" and "DAA" PRs reviewed today and merged soon.
    • jaspervdm: Yes all sounds good
  • antiochp: Are we supposed to be cutting a beta today? Or later this week?

    • jaspervdm: I would prefer to delay, it was planned for today.
    • antiochp: Yeah today is a bit of a stretch.
    • lehnberg: So what should the aim be? fix-fees and daa merged before beta?
    • antiochp: I think so yeah.
    • lehnberg: Thursday realistic? With deadline to merge tomorrow?
    • antiochp: I'd be good with aiming for Thursday.
    • lehnberg: So that thursday is spent on beta-cutting?
    • tromp: Ok with me.
    • jaspervdm: Yup.
    • lehnberg: Oki so tomorrow everything should be merged.
    • antiochp: Ideally yes. Keep reminding people here or in node or wallet dev if anybody still needs things to be reviewed or re-reviewed (just so we don't miss a review for any reason). Anything else 5.0.0 related?
    • jaspervdm: Think that's it.

5. Accelerating development

  • antiochp: Ok "accelerating development" via "Non ego utilized work acceleration for development". Is newjack777 around? @jankie1800? I think the concern could probably be summarized as "we need more devs", which is fair.

    • lehnberg: "we need more devs and we should make it more straight forward to onboard devs as paid devs".

    Maybe we could set up one-off grants? give out to people who contribute?

  • antiochp: I would push back on "The funds were not earmarked for just X programmers to pull from". This was never the intention and as far as I'm aware, not the current situation. Anybody is free to put a proposal together.

    • 👍: cekickafa
    • phyro: Agree. I'm also not sure what is meant with necessary to fight stagnation. From what I understand, Grin wouldn't be a protocol that changes often.
    • tromp: The wallet will need to keep changing, the consensus core not so much.
    • antiochp: All that said - these are definitely concerns we can continue (and will continue) to discuss. Not sure if anything specific is actionable right now.
    • phyro: Would be great if newjack777 was around to explain in more details, but if the summary is really "we need more devs" then yes, definitely.

6. Other questions

None.

Meeting adjourned.