Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"data_dir" option has been broken #251

Closed
GHLover opened this issue Nov 2, 2019 · 2 comments
Closed

"data_dir" option has been broken #251

GHLover opened this issue Nov 2, 2019 · 2 comments
Labels
P3: Fix if time Nice to have, does not block release
Milestone

Comments

@GHLover
Copy link

GHLover commented Nov 2, 2019

The data_dir option in the grin-wallet command line has been broken. Instead of utilizing the supplied directory it will actually create it's own directory.

Correct / old behavior:

grin-wallet --data_dir="/grin/"

This will place a wallet.seed file inside of /grin/ along with creating sub-directories (db, etc)

Buggy / current behavior:

grin-wallet --data_dir="/grin/"

This will instead ignore the data_dir option and instead place everything inside of /grin/wallet_data/. It has created a different base directory than the one specified and different than previous behavior

@yeastplume
Copy link
Member

Thanks for reporting, will have this fixed on master soon but the fix likely won't be released until 3.0.0

@yeastplume yeastplume added this to the 3.0.0 milestone Nov 4, 2019
@lehnberg lehnberg added the P3: Fix if time Nice to have, does not block release label Nov 12, 2019
@yeastplume
Copy link
Member

yeastplume commented Dec 3, 2019

I'm going to leave this functionality as is, as the new wallet APIs all heavily rely on the concept of a top_level_dir, which contains the grin-wallet.toml file, which in turn specifies the location of the wallet's data files (which users shouldn't really need to be concerned with). There should be no need to manually specify the location wallet data files without referencing the top level directory.

To alleviate the potential for confusion I'll rename the data_dir command line switch to top_level_dir for consistency with the APIs, but the behavior as currently exists is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: Fix if time Nice to have, does not block release
Projects
None yet
Development

No branches or pull requests

3 participants