Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stratum server code uses of global "edge_bits" value #1874

Closed
bladedoyle opened this issue Oct 29, 2018 · 3 comments
Closed

Update stratum server code uses of global "edge_bits" value #1874

bladedoyle opened this issue Oct 29, 2018 · 3 comments
Labels

Comments

@bladedoyle
Copy link
Contributor

bladedoyle commented Oct 29, 2018

This does not look right to me:
https://github.com/mimblewimble/grin/blob/master/servers/src/mining/stratumserver.rs#L635

It does not make sense to have a single stratum-wide value for "edge_bits" (or cuckoo_size) now that we allow multiple sizes chosen by the miner on a per solution basis.

It looks like all the "status" stuff needs to be updated also

Does a single "minimum_share_difficulty" setting applied to all solution sizes (in the grin-server.toml) still make sense?

@bladedoyle
Copy link
Contributor Author

I disagree with the "enhancement" tag. Adding multiple POW was an enhancement. Unmade changes needed as a result of that enhancement is a bug/technical debt. (imo at least)

@lehnberg lehnberg added bug and removed enhancement labels Oct 29, 2018
@lehnberg
Copy link
Collaborator

Apologies, I read it as though something additional was needed beyond what was already in there. Not that previous functionality broke as part of changes. Updated.

@yeastplume
Copy link
Member

I think we're okay here now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants