Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txhashet filenames currently ending in ... #2351

Closed
antiochp opened this issue Jan 12, 2019 · 1 comment
Closed

txhashet filenames currently ending in ... #2351

antiochp opened this issue Jan 12, 2019 · 1 comment
Labels
bug must-have Required for the associated milestone
Milestone
Mainnet

Comments

@antiochp
Copy link
Member

Related - #2325

Looks like we inadvertently included the nice pretty ... in the block hash string itself... (and not just in the UI).

  • displayed/used block hash should be 12 digits long
  • UI is free to add ... to the end, but this should not be used in the filename (obviously)

Lets be more careful with seemingly innocuous changes like this in the future. We should have considered any and all usage of block.hash() here and clearly missed one, and probably other uses.
@antiochp antiochp added bug must-have Required for the associated milestone labels Jan 12, 2019
@antiochp antiochp added this to the Mainnet milestone Jan 12, 2019
@svechinsky svechinsky mentioned this issue Jan 12, 2019
Merged
@garyyu
Copy link
Contributor

garyyu commented Jan 13, 2019

Closed by #2355

@garyyu garyyu closed this as completed Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug must-have Required for the associated milestone
Projects
None yet
Milestone
Mainnet
Development

No branches or pull requests
2 participants
@garyyu @antiochp