Skip to content

Commit ce2c5a8

Browse files
authored
Merge pull request #4 from mimiro-io/improvement/expose-context-on-return-ec
expects and returns context
2 parents bfb2d70 + cdb3b33 commit ce2c5a8

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

sample/sample_transform.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func (dl *SampleTransform) Transform(ec *egdm.EntityCollection) (*egdm.EntityCol
3535
if err != nil {
3636
return nil, ct.Err(err, 1)
3737
}
38-
return &egdm.EntityCollection{Entities: result}, nil
38+
return &egdm.EntityCollection{Entities: result, NamespaceManager: ec.NamespaceManager}, nil
3939
}
4040

4141
type Result struct {

sample/sample_transform_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ func TestNewSampleDataLayer(t *testing.T) {
5050
// test transform, by creating entity collection with example entities
5151
data := `
5252
[
53+
{
54+
"id" : "@context",
55+
"namespaces" : {}
56+
},
5357
{
5458
"id": "http://example.com/1",
5559
"props": {
@@ -67,7 +71,7 @@ func TestNewSampleDataLayer(t *testing.T) {
6771
reader := strings.NewReader(data)
6872

6973
nsManager := egdm.NewNamespaceContext()
70-
parser := egdm.NewEntityParser(nsManager).WithNoContext().WithExpandURIs()
74+
parser := egdm.NewEntityParser(nsManager).WithExpandURIs()
7175
ec, err := parser.LoadEntityCollection(reader)
7276
if err != nil {
7377
t.Error(err)
@@ -81,7 +85,7 @@ func TestNewSampleDataLayer(t *testing.T) {
8185
}
8286

8387
// load a new entity collection from the response
84-
parser = egdm.NewEntityParser(egdm.NewNamespaceContext()).WithNoContext().WithExpandURIs()
88+
parser = egdm.NewEntityParser(egdm.NewNamespaceContext()).WithExpandURIs()
8589
ec1, err := parser.LoadEntityCollection(resp.Body)
8690
if err != nil {
8791
t.Error(err)

web.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func (ws *transformWebService) health(c echo.Context) error {
141141

142142
func (ws *transformWebService) transform(c echo.Context) error {
143143
parser := egdm.NewEntityParser(egdm.NewNamespaceContext())
144-
parser.WithNoContext().WithExpandURIs()
144+
parser.WithExpandURIs()
145145
ec, err := parser.LoadEntityCollection(c.Request().Body)
146146

147147
if err != nil {
@@ -158,7 +158,6 @@ func (ws *transformWebService) transform(c echo.Context) error {
158158
c.Response().Header().Set(echo.HeaderContentType, echo.MIMEApplicationJSONCharsetUTF8)
159159
c.Response().WriteHeader(http.StatusOK)
160160

161-
transformed.SetOmitContextOnWrite(true)
162161
err = transformed.WriteEntityGraphJSON(c.Response().Writer)
163162
if err != nil {
164163
ws.logger.Warn(err.Error())

0 commit comments

Comments
 (0)