Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken JRuby support #147

Closed
mrbrdo opened this issue Sep 24, 2013 · 16 comments
Closed

Broken JRuby support #147

mrbrdo opened this issue Sep 24, 2013 · 16 comments

Comments

@mrbrdo
Copy link
Contributor

mrbrdo commented Sep 24, 2013

At some point in time you broke JRuby support by using fork (unsupported) in https://github.com/nadarei/mina/blob/master/lib/mina/exec_helpers.rb

You could perhaps use threads for this purpose and rescue Interrupt instead of trap('INT').

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Sep 30, 2013

PS: I've monkey-patched to use threads and seems to work fine

@substars
Copy link

substars commented Oct 2, 2013

👍

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Oct 2, 2013

Here comes the PR.

@designium
Copy link

Could you share the code, please?

It would be great if the Mina site showed that it was incompatible with Jruby. Wasted hours.

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Oct 13, 2013

Show code? Don't you see the pull request?

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Nov 8, 2013

@rstacruz could you consider merging my PR? We JRuby users would really appreciate it.

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Nov 8, 2013

@designium if you need it now, add 'mina-extras' to your Gemfile and in your deploy.rb require 'mina-extras/jruby-patch'

@mrbrdo
Copy link
Contributor Author

mrbrdo commented May 7, 2014

@rstacruz any response would be nice.

@d4be4st
Copy link
Member

d4be4st commented Jul 5, 2015

I really do not know if this is fixed. If someone tried using newer mina version with JRuby and doesnt work please repoen the task

@d4be4st d4be4st closed this as completed Jul 5, 2015
@xurde
Copy link

xurde commented Sep 10, 2015

Hi @mrbrdo
So did this finally got solved and properly patched for the following versions?
The status looks uncertain.
Thanks!

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Sep 10, 2015

Yes since the patch is merged I think it should work now.

@ineu
Copy link
Contributor

ineu commented Apr 1, 2017

Sorry to raise the old issue, but this seems to be broken again as of 1.0.6. Trying to run it under jruby 9, I get the following error:

> $ mina deploy
mina aborted!
NotImplementedError: fork is not available on this platform

@zhum
Copy link

zhum commented Jul 7, 2017

The same problem! Please, fix for jruby...

@vicvans20
Copy link

Same problem with jruby 9.1.7.0

@prasadsurase
Copy link

Same problem with jruby 9.1.15.0

@zhum
Copy link

zhum commented Mar 1, 2018

Please, accept my patch... #581
I use it in production, my patched mina works fine with jruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants