-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken JRuby support #147
Comments
PS: I've monkey-patched to use threads and seems to work fine |
👍 |
Here comes the PR. |
Could you share the code, please? It would be great if the Mina site showed that it was incompatible with Jruby. Wasted hours. |
Show code? Don't you see the pull request? |
@rstacruz could you consider merging my PR? We JRuby users would really appreciate it. |
@designium if you need it now, add 'mina-extras' to your Gemfile and in your deploy.rb |
@rstacruz any response would be nice. |
I really do not know if this is fixed. If someone tried using newer mina version with JRuby and doesnt work please repoen the task |
Hi @mrbrdo |
Yes since the patch is merged I think it should work now. |
Sorry to raise the old issue, but this seems to be broken again as of 1.0.6. Trying to run it under jruby 9, I get the following error:
|
The same problem! Please, fix for jruby... |
Same problem with jruby 9.1.7.0 |
Same problem with jruby 9.1.15.0 |
Please, accept my patch... #581 |
At some point in time you broke JRuby support by using fork (unsupported) in https://github.com/nadarei/mina/blob/master/lib/mina/exec_helpers.rb
You could perhaps use threads for this purpose and
rescue Interrupt
instead oftrap('INT')
.The text was updated successfully, but these errors were encountered: