Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared bundle path not symlinked #156

Closed
joeystdio opened this issue Dec 3, 2013 · 2 comments
Closed

shared bundle path not symlinked #156

joeystdio opened this issue Dec 3, 2013 · 2 comments

Comments

@joeystdio
Copy link

Every deployment it installs all the gems again in its own .vendor/bundle folder instead of the symlinked ./shared/bundle folder. The symlink never gets created.

Or am I doing something very wrong?

@jeremy
Copy link

jeremy commented Feb 15, 2014

bundle_path defaults to .vendor/bundle/: https://github.com/nadarei/mina/blob/master/lib/mina/bundler.rb#L20

The bundle/ dir within that path is symlinked to shared_path/bundle: https://github.com/nadarei/mina/blob/master/lib/mina/bundler.rb#L40

So you should see a symlink within the dir, not a symlink from .vendor/bundle itself.

Reviewing the git history, I'm unclear why it's set up this way. Bundle install can specify the shared path directly, event. No symlink required. That gives releases the freedom to change their shared bundle, which has been necessary on certain tricky upgrades, like Ruby 1.9 + Psych gem vs stdlib.

@d4be4st
Copy link
Member

d4be4st commented Jul 5, 2015

This is fixed.

@d4be4st d4be4st closed this as completed Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants