Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network issues in test-examples #123

Closed
alineyyy opened this issue Jun 4, 2024 · 3 comments · Fixed by #126
Closed

Network issues in test-examples #123

alineyyy opened this issue Jun 4, 2024 · 3 comments · Fixed by #126
Assignees
Labels

Comments

@alineyyy
Copy link
Contributor

alineyyy commented Jun 4, 2024

example_stacked.py and example_density.py can't pass in the test-examples because of some network connection errors.

Some alternatives should be purposed to solve these issues.

@alineyyy alineyyy assigned alineyyy and chaithyagr and unassigned alineyyy Jun 4, 2024
@paquiteau
Copy link
Member

Well this is a bit tricky.

The only way I see for now is to propose to download image data from somewhere else than the brainweb dataset (using brainweb_dl ) or we commit the image to the repo ( I am not for this, adding huge binary blob is not so good for git).

@paquiteau paquiteau added the CI label Jun 5, 2024
@paquiteau
Copy link
Member

paquiteau commented Jun 5, 2024

A solution might be to use the caching mechanism of github actions1. The brainweb data is downloaded in ~/.cache/brainweb (or whatever is the environment variable $BRAINWEB_DIR) So we could setup a cache to both speed things up and make less call to download the phantoms.

Footnotes

  1. https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows

@chaithyagr
Copy link
Member

Thats a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants