Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minder should validate the config exists #4513

Closed
lukehinds opened this issue Sep 17, 2024 · 2 comments · Fixed by #5387
Closed

Minder should validate the config exists #4513

lukehinds opened this issue Sep 17, 2024 · 2 comments · Fixed by #5387
Assignees
@mesembria
Labels
bug Something isn't working P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@lukehinds
Copy link
Contributor

Describe the issue

I made a mistake in giving an incorrect path, yet no error handling occurs

Image

To Reproduce

No response

What version are you using?

No response
@lukehinds lukehinds added the bug Something isn't working label Sep 17, 2024
@psekar
Copy link
Contributor

psekar commented Sep 18, 2024 •
edited
Loading

I had minder 0.0.50 installed via brew. I see a error message as below

minder auth login --config test.txt Error reading config file: open test.txt: no such file or directoryYour browser will now be opened to: http://localhost:55587/login

In the latest, minder 0.0.63, it is behaving like reported. Happy to take a look at this.

@eleftherias
Copy link
Contributor

Thanks @psekar! I'll assign the issue to you.

@evankanderson evankanderson added the P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage label Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Planned Work Jan 30, 2025
@mesembria mesembria moved this from Backlog to In Progress in Planned Work Jan 30, 2025
@mesembria mesembria self-assigned this Jan 30, 2025
mesembria added a commit that referenced this issue Jan 31, 2025
@mesembria
Adds check to ensure config file exists. Fixes: #4513
24d5e3d
@mesembria mesembria linked a pull request Jan 31, 2025 that will close this issue
Adds check to ensure config file exists. Fixes: #4513 #5387
Merged
10 tasks
@mesembria mesembria mentioned this issue Jan 31, 2025
Merged
10 tasks
mesembria added a commit that referenced this issue Jan 31, 2025
@mesembria
Adds check to ensure config file exists. Fixes: #4513
fbbeef1
mesembria added a commit that referenced this issue Feb 3, 2025
@mesembria
Adds check to ensure config file exists. Fixes: #4513
835ac83
@github-project-automation github-project-automation bot moved this from In Progress to Done in Planned Work Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mesembria mesembria

Labels
bug Something isn't working P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
Planned Work
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds check to ensure config file exists. Fixes: #4513 mindersec/minder
5 participants
@psekar @mesembria @eleftherias @lukehinds @evankanderson