Question: refactoring to fully use pytest

[betaboon]

would you be interested in me refactoring the tests to fully and consistently use pytest?

i also have some ideas on how to get rid of the need to run docker compose.

[mindflayer]

What is the problem with using Docker Compose?

[betaboon]

What is the problem with using Docker Compose?

you have to start it up manually before the tests. so running pytest is not sufficient.

[mindflayer]

Back to the first question: the reason for having a mix of different types of tests - not 100% sure if it's still relevant - was that Mocket as a testing tool has to be compatible with any tool around, especially if it comes from the standard library. So, if some tests are relying on unittest, that's the reason behind.

[betaboon]

to test for compatibility with pytest and stdlib.unittest maybe it would be good to cover that in dedicated tests?

[mindflayer]

Mocket is not a framework people use to write software with. It's primarily a tool for testing, so tests are a first-class citizen in here, as important as the code itself.
This said, maybe show me an example of what you have in mind, but please don't get rid of the different cases (test-classes, test functions, implementing fixtures, based on unittest, async, etc). Every test was added to cover a specific use-case.

[betaboon]

I'll leave tests exactly as they are then :)

regarding docker-compose.

• for httpbin we could use httpbin directly (or pytest-httpbin, which triggered my question regarding switching fully to pytest, as pytest-httpbin also has support for https)
• for redis we could use testcontainers-on-whales to spinup the container dynamically

[mindflayer]

• for httpbin we could use httpbin directly

That's was I used to do. I even tried other services similar to httpbin, the first I used. They are just not reliable enough to have a stable CI.

[betaboon]

• for httpbin we could use httpbin directly

That was I used to do, and I tried three different services - including httpbin -. They are just now reliable enough to have a stable CI.

Ah. I'm not talking about the service, but about the standalone Python package.

[mindflayer]

The PyPI package is exactly what I use (through its Docker image): https://pypi.org/project/httpbin/

[mindflayer]

If you are considering spawning the service from Mocket testing code, I believe it's way cleaner keeping the two things separated.
There is a Makefile that does all the magic, I don't think that adding more Python code for spawning a local server would help in any way.

[betaboon]

ok i can live with that.
just fyi tho, i cannot use the makefile as it tries to patch the hosts-file in-place, which won't work on my system, as that file is immutable ;)

[mindflayer]

Isn't fixing the Bash script easier? :)
Just open an issue and I'll fix it, if not.

[betaboon]

"fixing" the bashscript wont do anything for me.
the way the tests are setup there are two requirements:

• the containers are running
• the hosts-file points certain domains to that container

conceptually that's impossible on systems like mine, where the hosts-file just cannot be changed.
so actually there is no fix for that.

which is what spinning the containers up from within python would be able to address, as both requirements would not be there anymore.

[mindflayer]

What OS are you using? And how do you specify a new host pointing to a fixed IP?

[mindflayer]

which is what spinning the containers up from within python would be able to address, as both requirements would not be there anymore.

I still see simpler solutions, like using the IP of the container as a fall-back.

[betaboon]

I'm on nixos, i have to configure it in my system-configuration which then generates the hosts-file.

but yeah, that's a me problem :P

[mindflayer]

Using the hostname if we are able to add it, or the IP as a fall-back, should be enough.

[mindflayer]

I'm on nixos

Never ever tried that animal. :)

[mindflayer]

It used to be possible to only run the tests relying on Mocket with make safetest, forgetting about real-socket ones. It looks like something changed in the Redis client, and it's now failing. It's worth investigating.

[mindflayer]

FYI I have just fixed make safetest.