Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing space after sparkline #73

Open
PKlknr opened this issue Jan 15, 2023 · 1 comment
Open

Trailing space after sparkline #73

PKlknr opened this issue Jan 15, 2023 · 1 comment

Comments

@PKlknr
Copy link

PKlknr commented Jan 15, 2023

Hi, the svg for sparklines is a bit wider than the paths - this becomes apparent for example when adding a border:
image

This seems to be due to Contex.Sparkline.draw calculating the viewbox width as sparkline.length + 1. Without looking too deeply, changing that to length - 1 seems to fix the issue.

PS: While writing this I noticed the same fix in 56f7ec7 Maybe that could be cherry-picked?

Thanks for this very cool lib!

@mindok
Copy link
Owner

mindok commented Jan 17, 2023

I'll take a look a little later - got some crunchy deadlines on at the moment. There are a few improvements to sparklines in the PR that @fceruti put together, so makes sense to pull that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants