Potential Data Race Identified in MatrixTransposeKernel

[zhenrongliew]

Potential Data Race Identified in MatrixTransposeKernel

Description:

My team and I have been working on a verification project for CUDA kernels called faial. faial has reported a potential data-race in mindspore/ccsrc/plugin/device/gpu/kernel/cuda_impl/cuda_ops/matrix_transpose_impl.cu on line 34.

output[b_stride + c * row + r] = input[pos];
       ^^^^^^^^^^^^^^^^^^^^^^

Our tool reports potential data-races unless we introduce some pre-conditions on kernel parameters col and row:

• Parameter col must be positive: col > 0
• Parameter row must be positive: row > 0
• Parameters row and col must be equal: row == col

Do these conditions match your expectations?

We can submit a pull-request that adds the following pre-condition to your kernels. Would that be a welcome addition?

   if (col <= 0 || row <= 0 || row != col) {
     return;
   }

[Ash-Lee233]

do you have pr url? we will review your pr ASAP

[zhenrongliew]

Here is the link to the pull request. #266